feat(clickhouse_driver): Respect data_collection.database_query_data option - #6938
Open
ericapisani wants to merge 1 commit into
Open
feat(clickhouse_driver): Respect data_collection.database_query_data option#6938ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
…option Honour the new `data_collection.database_query_data` experimental option when deciding whether to attach `db.params` and `db.result` to spans and breadcrumbs. When the option is set, it takes precedence over `send_default_pii`; otherwise, fall back to the existing PII-based behavior. Refs PY-2587 Refs #6747
ericapisani
marked this pull request as ready for review
July 29, 2026 18:47
Contributor
Codecov Results 📊✅ 99316 passed | ⏭️ 6781 skipped | Total: 106097 | Pass Rate: 93.61% | Execution Time: 355m 17s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2498 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.87% 89.88% +0.01%
==========================================
Files 193 193 —
Lines 24656 24678 +22
Branches 8786 8806 +20
==========================================
+ Hits 22158 22180 +22
- Misses 2498 2498 —
- Partials 1400 1400 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClickHouse driver integration now respects the experimental
data_collection.database_query_dataoption when deciding whether to attachdb.paramsanddb.resultto spans and breadcrumbs.When the option is set, it takes precedence over
send_default_pii:database_query_data: Trueattaches query params and results even without PII enabled, anddatabase_query_data: Falsesuppresses them even whensend_default_pii=True. When the option is not set, behavior is unchanged and falls back to the existingsend_default_piicheck.Refs PY-2587
Refs #6747