Skip to content

fix(aws-lambda): fix flake in aws lambda tests #6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloDeputter merged 5 commits into from
Jul 30, 2026
+7 −6
Merged

fix(aws-lambda): fix flake in aws lambda tests #6937

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09206c5
fix(aws-lambda): Increase shutdown timeout for lambda test infrastruc…
pabloDeputter Jul 29, 2026
3b203d2
fix(aws-lambda): change container startup to lazy
pabloDeputter Jul 30, 2026
67fb31e
fix(aws-lambda): finalize SAM teardown flake fix
pabloDeputter Jul 30, 2026
0771f04
fix(aws-lambda): one last check with temporary workflow
pabloDeputter Jul 30, 2026
87862c3
chore(aws-lambda): remove temporary aws-flake workflow
pabloDeputter Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions tests/integrations/aws_lambda/test_aws_lambda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

DOCKER_NETWORK_NAME = "lambda-test-network"
SAM_TEMPLATE_FILE = "sam.template.yaml"
SAM_SHUTDOWN_TIMEOUT = 10


@pytest.fixture(scope="session", autouse=True)
Expand Down Expand Up @@ -54,7 +55,7 @@ def test_environment():
"--template",
SAM_TEMPLATE_FILE,
"--warm-containers",
"EAGER",
"LAZY", # Start each Docker container on its function's first invocation
"--docker-network",
DOCKER_NETWORK_NAME,
],
Expand All @@ -78,13 +79,13 @@ def before_test():

finally:
print("[test_environment fixture] Tearing down AWS Lambda test infrastructure")

process.terminate()
process.wait(timeout=10) # Give it time to shut down gracefully

# Force kill if still running
if process.poll() is None:
try:
# Teardown is typically ~7s; escalate with kill if SAM exceeds this.
process.wait(timeout=SAM_SHUTDOWN_TIMEOUT)
except subprocess.TimeoutExpired:
process.kill()
process.wait()


@pytest.fixture(autouse=True)
Expand Down
Loading