feat(solidstart): Auto-wire orchestrion build-time instrumentation - #22827
Merged
Conversation
`withSentry()` now adds the orchestrion bundler plugin to the SolidStart/Nitro build automatically, gated on the shared `buildTimeInstrumentation` opt-out. Follows Nuxt's `setupOrchestrion` pattern: push the rollup code transform and force-inline `INSTRUMENTED_MODULE_NAMES` into Nitro externals. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Extend the solidstart e2e app with mysql/ioredis routes and a Docker-backed test asserting the `auto.db.orchestrion.*` spans, proving the auto-wiring. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
buglinger run (edited by: @nicohrubec) |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 16dd435. Configure here.
Hoist the `rollup:before` config cast into one narrowing with a justification comment, replacing the duplicate double-cast. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chargome
marked this pull request as ready for review
July 30, 2026 08:09
chargome
requested review from
andreiborza,
nicohrubec and
s1gr1d
and removed request for
a team
July 30, 2026 08:09
andreiborza
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withSentry()now adds the orchestrion bundler plugin to the SolidStart/Nitro build automatically, so instrumented DB drivers getdiagnostics_channelpublishers injected at build time with no manual setup. Follows Nuxt'ssetupOrchestrionpattern and is gated on the sharedbuildTimeInstrumentationopt-out.The externals-inlining is set statically on the returned
serverconfig (not in a hook) because externalization must land before Rollup normalizesexternal.Closes #22687