Attempt to fix flaky tests caused by modifying the same test apps. - #9929
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors inspector_integration_test.dart to leverage the built-in temporary directory support in FlutterTestEnvironment instead of manually copying and deleting the fixture directory. Feedback focuses on the change to the default value of useTempDirectory in FlutterTestEnvironment from false to true. This change would cause all tests using this environment to copy their fixtures, introducing unnecessary disk I/O. It is recommended to keep the default as false and explicitly enable useTempDirectory: true only in the integration test where it is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eval_on_dart_library.dart and inspector_integration_test.dart have been flaky. The hypothesis is that this was caused by multiple integration tests sharing the same fixture workspace.