build/bake: skip registry identity validation without registry login - #266
Open
crazy-max wants to merge 3 commits into
Open
build/bake: skip registry identity validation without registry login#266crazy-max wants to merge 3 commits into
crazy-max wants to merge 3 commits into
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
marked this pull request as ready for review
July 29, 2026 12:33
crazy-max
marked this pull request as draft
July 29, 2026 12:46
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
marked this pull request as ready for review
July 29, 2026 14:23
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/docker/cli/actions/runs/30449872409/job/90569130577#step:3:173
This change prevents
setup-registry-identitiesfrom failing non-push image builds when registry login would not run under the current workflow logic.The setup workflow now accepts a
registry-loginboolean and skips dependency installation plus registry identity validation when it is false. The build and bake workflows passinputs.push && inputs.output == 'image', which matches the current condition used for registry login.A caller can pass Docker Hub OIDC registry identities with
connection_id: ${{ vars.FOO }}while running withoutput: imageandpush: false. If that variable resolves to an empty value, validation used to fail even though registry login was disabled and the identity would never be used. This keeps validation strict when login can happen, but avoids failing builds for unused registry identity config.Also add extra commit to report errors cleanly with
core.setFailed.