Skip to content

vendor: github.com/moby/go-archive v0.3.2 - #7142

Merged
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_go_archive_0.3.2
Jul 31, 2026
Merged

vendor: github.com/moby/go-archive v0.3.2#7142
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_go_archive_0.3.2

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

full diff: moby/go-archive@v0.3.1...v0.3.2

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

full diff: moby/go-archive@v0.3.1...v0.3.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vvoland
vvoland merged commit e9452d6 into docker:master Jul 31, 2026
107 checks passed

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The bump from v0.3.1 to v0.3.2 introduces a resolveArchivePath compatibility workaround and associated helpers (resolveHardlinkTarget, resolveFSRootPath, walkLink) to handle intermediate symlinks during tar extraction with os.Root confinement. The logic is sound: the final write always goes through os.Root, which hard-bounds all operations within the extraction root regardless of path computation.

Dismissed security findings (review manually)

  • vendor/github.com/moby/go-archive/archive.go:481resolveFSRootPath uses raw os.Lstat/os.Readlink (not openat-chain–protected) for path computation in the symlink-fallback path (verifier mitigation: the final os.Root write re-confines the result; filepath.Rel + filepath.IsLocal checks catch escapes before the write; worst-case is writing to a different path within root, not an escape — same accepted TOCTOU limitation documented in the code comments).

@thaJeztah
thaJeztah deleted the bump_go_archive_0.3.2 branch July 31, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants