Skip to content

vendor: github.com/moby/go-archive v0.3.1 - #7140

Merged
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_go_archive_0.3.1
Jul 31, 2026
Merged

vendor: github.com/moby/go-archive v0.3.1#7140
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_go_archive_0.3.1

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

full diff: moby/go-archive@v0.3.0...v0.3.1

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

full diff: moby/go-archive@v0.3.0...v0.3.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This vendor bump of from v0.3.0 to v0.3.1 looks correct. Two code changes were reviewed in :

  1. ** defer block**: The three Close calls now suppress . This is intentional to reduce spurious log noise when the reader drops the pipe early — correctly handles wrapped variants, and the writer-side error is irrelevant once the reader has already abandoned the stream.

  2. ** TypeDir guard removal**: The previous guard is removed, so directory entries now also go through parent-creation logic. The function uses to find only the parent, not the entry itself, so it never tries to pre-create the directory being extracted. Top-level directories are still fast-pathed by the check. If an explicit tar entry for the parent arrives later, will overwrite permissions/ownership correctly. No fd leaks were found — the Chown/Chmod failure paths both call before returning.

@vvoland
vvoland merged commit 2465fca into docker:master Jul 31, 2026
106 of 108 checks passed
@thaJeztah
thaJeztah deleted the bump_go_archive_0.3.1 branch July 31, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants