vendor: github.com/moby/go-archive v0.3.1 - #7140
Conversation
full diff: moby/go-archive@v0.3.0...v0.3.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This vendor bump of from v0.3.0 to v0.3.1 looks correct. Two code changes were reviewed in :
-
** defer block**: The three Close calls now suppress . This is intentional to reduce spurious log noise when the reader drops the pipe early — correctly handles wrapped variants, and the writer-side error is irrelevant once the reader has already abandoned the stream.
-
** TypeDir guard removal**: The previous guard is removed, so directory entries now also go through parent-creation logic. The function uses to find only the parent, not the entry itself, so it never tries to pre-create the directory being extracted. Top-level directories are still fast-pathed by the check. If an explicit tar entry for the parent arrives later, will overwrite permissions/ownership correctly. No fd leaks were found — the Chown/Chmod failure paths both call before returning.
full diff: moby/go-archive@v0.3.0...v0.3.1
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)