gx2: Add GX2GetLastFrame, GX2GetLastFrameGamma documentation - #451
Open
CoolPenguin27 wants to merge 1 commit into
Open
gx2: Add GX2GetLastFrame, GX2GetLastFrameGamma documentation#451CoolPenguin27 wants to merge 1 commit into
CoolPenguin27 wants to merge 1 commit into
Conversation
| * The scan-target to source from. | ||
| * | ||
| * \param texture | ||
| * A pointer to the texture to store the frame. The resulting surface format is #GX2_SURFACE_FORMAT_SRGB_R8_G8_B8_A8. |
Contributor
There was a problem hiding this comment.
A pointer to the texture to store the frame
This makes it sound a bit like only the image in texture is updated. Maybe something like
Suggested change
| * A pointer to the texture to store the frame. The resulting surface format is #GX2_SURFACE_FORMAT_SRGB_R8_G8_B8_A8. | |
| * A pointer to store the texture of the last frame to. The resulting surface format is #GX2_SURFACE_FORMAT_SRGB_R8_G8_B8_A8. |
would make this more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mainly did this to document the surface format, which is GX2_SURFACE_FORMAT_SRGB_R8_G8_B8_A8.