Skip to content

fix: Remove SCC attribute from .devfile.yaml - #266

Open
ibuziuk wants to merge 1 commit into
mainfrom
ibuziuk-patch-5
Open

fix: Remove SCC attribute from .devfile.yaml#266
ibuziuk wants to merge 1 commit into
mainfrom
ibuziuk-patch-5

Conversation

@ibuziuk

@ibuziuk ibuziuk commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Removed security context constraint attribute from devfile.

Screenshot 2026-07-31 at 16 44 26

Since we enabled nested containers, I do not think this attribute is needed anymore

Summary by CodeRabbit

  • Chores
    • Updated the development environment configuration by removing an obsolete container-build setting.

Removed security context constraint attribute from devfile.
@ibuziuk
ibuziuk requested review from SDawley, dkwon17 and svor as code owners July 31, 2026 14:44
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a2a73d6c-99fc-4c52-8c0b-48987630f94a

📥 Commits

Reviewing files that changed from the base of the PR and between 131c397 and 5bca73a.

📒 Files selected for processing (1)
  • .devfile.yaml
💤 Files with no reviewable changes (1)
  • .devfile.yaml

📝 Walkthrough

Walkthrough

This change removes the controller.devfile.io/scc: container-build attribute from the attributes section of .devfile.yaml. No other configuration changes are made.

Changes

Devfile Attribute Removal

Layer / File(s) Summary
Remove scc attribute
.devfile.yaml
The controller.devfile.io/scc: container-build line is deleted, leaving only controller.devfile.io/storage-type: ephemeral in the attributes section.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: dkwon17, sdawley, svor

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the SCC attribute from .devfile.yaml, which is the only change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ibuziuk-patch-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Pull Request UBI 10 images published ✨

Base: quay.io/devfile/base-developer-image:ubi10-pr-266
UDI: quay.io/devfile/universal-developer-image:ubi10-pr-266

@github-actions

Copy link
Copy Markdown

Pull Request images published ✨

Base: quay.io/devfile/base-developer-image:pr-266
UDI: quay.io/devfile/universal-developer-image:pr-266

@dkwon17

dkwon17 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

@ibuziuk thank you for the PR, could you please signoff the commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants