chore: Add Web IDE link on pull request creation - #265
Conversation
This workflow adds a link to open the pull request in Web IDE when a pull request is opened.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughA new GitHub Actions workflow runs when a pull request opens. It grants the required repository permissions and invokes ChangesWeb IDE workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/.github/workflows/try-in-web-ide.yaml (1)
1-29: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winMove the Web IDE workflow into the scanned directory.
.github/workflows/.github/workflows/try-in-web-ide.yamlis not a reachable GitHub Actions workflow path. Move it to.github/workflows/try-in-web-ide.yamlso PRs can trigger the Web IDE link job.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/.github/workflows/try-in-web-ide.yaml around lines 1 - 29, Move the workflow containing the add-link job and try-in-web-ide step from the nested .github/workflows location to the repository’s reachable .github/workflows/try-in-web-ide.yaml path, preserving its existing trigger, permissions, and action configuration.
🧹 Nitpick comments (1)
.github/workflows/.github/workflows/try-in-web-ide.yaml (1)
26-26: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the action reference instead of using
@main.
redhat-actions/try-in-web-ide@mainreferences a mutable branch. Combined withpull_request_targetandsecrets.GITHUB_TOKENwrite permissions, any change pushed to that branch runs immediately with elevated permissions on every opened pull request, without review. Official documentation for this action pins to a version tag such asv1.Pin the action to a release tag or commit SHA.
🔒 Proposed fix to pin the action reference
- uses: redhat-actions/try-in-web-ide@main + uses: redhat-actions/try-in-web-ide@v1🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/.github/workflows/try-in-web-ide.yaml at line 26, Update the redhat-actions/try-in-web-ide action reference from the mutable `@main` branch to a stable release tag such as `@v1` or a specific commit SHA, while preserving the existing workflow behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/.github/workflows/try-in-web-ide.yaml:
- Around line 1-29: Move the workflow containing the add-link job and
try-in-web-ide step from the nested .github/workflows location to the
repository’s reachable .github/workflows/try-in-web-ide.yaml path, preserving
its existing trigger, permissions, and action configuration.
---
Nitpick comments:
In @.github/workflows/.github/workflows/try-in-web-ide.yaml:
- Line 26: Update the redhat-actions/try-in-web-ide action reference from the
mutable `@main` branch to a stable release tag such as `@v1` or a specific commit
SHA, while preserving the existing workflow behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0be736b6-9587-4491-bee8-32ba56a36ac4
📒 Files selected for processing (1)
.github/workflows/.github/workflows/try-in-web-ide.yaml
|
Pull Request UBI 10 images published ✨ Base: quay.io/devfile/base-developer-image:ubi10-pr-265 |
|
Pull Request images published ✨ Base: quay.io/devfile/base-developer-image:pr-265 |
|
@ibuziuk thank you for the PR, could you please signoff the commit? |
This workflow adds a link to open the pull request in Web IDE when a pull request is opened.
Summary by CodeRabbit