Install-DbaFirstResponderKit: Added ability to create certificates to let public execute FRK procedures - #10463
Open
ReeceGoding wants to merge 1 commit into
Open
Install-DbaFirstResponderKit: Added ability to create certificates to let public execute FRK procedures#10463ReeceGoding wants to merge 1 commit into
ReeceGoding wants to merge 1 commit into
Conversation
…ures. Closes dataplat#10368 Also added sp_kill to existing ValidateSet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be warned, this may be terrible! Specifically:
CREATE USERpart of the original code was trying to solve.Type of Change
Invoke-ManualPester)Purpose
Added ability to create certificates to let public execute FRK procedures. Closes #10368
Also added
sp_killto existing ValidateSet.Approach
It started as an attempt to copy the "How to Grant Permissions to Non-DBAs" section here, but that set of steps assumes that you are in master. To make other databases also work, I had to expand that with the tricks mentioned here.
Commands to test
Install-DbaFirstResponderKitand specifically, the new-LetPublicExecuteparameter.Screenshots
Learning
Invoke-ManualPester -Path ./tests/Install-DbaFirstResponderKit.Tests.ps1 -ScriptAnalyzer -TestIntegrationfails if you don't have aC:\Tempfolder. If you know what you're doing, then you can add a new$config['temp'] = "/path/i/actually/have"line todbatools/tests/constants.local.ps1, but there is nothing anywhere to hint that you need to do that. Everything else I've ever wanted to change indbatools/tests/constants.local.ps1already had a placeholder.EXECUTE AS USER = 'guest'was a very bad idea. It seems unable to take the permissions from the certificate.Get-DbaDbUserdoes not see certificate-mapped users?