generate: stage local dependency closure before codegen - #2
Draft
tiborvass wants to merge 1 commit into
Draft
Conversation
tiborvass
force-pushed
the
agent/generate-stage-local-dependencies
branch
from
July 29, 2026 16:15
b198b29 to
10376b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new
ModuleSource.generateLocalDependenciesengine API. Before generating each managed PHP module,generateAll(the@generatefunction) andMod.generatestage the transitive local dependency closure onto the workspace viawithChanges, then generate against the staged workspace. This lets PHP module codegen see up-to-date dependency bindings, including dependencies owned by other SDKs.The existing
github.com/dagger/polyfill@maindependency is advanced to the module-generation scoping fix, so each generated changeset contains files for only that module.Depends on
ModuleSource.generateLocalDependencies✅ mergedThis is the PHP SDK equivalent of dagger/typescript-sdk#12 and dagger/go-sdk#12.
Validation
jq empty dagger.json(cd helpers/render-template && go test ./...)git diff --checkA full generation test was not run locally because the installed stable CLI (
v0.21.7) predates the CLI-1.0 engine API used here.