fix(rubocop): fix all RSpec/ContextWording violations - #2756
Merged
Conversation
Prefix 144 `context` descriptions with `when`/`with`/`without` across 53 spec files. Removes the RSpec/ContextWording exclude section from .rubocop_todo.yml. Includes 10 grammar cleanups from code review (acronym casing, gerund forms, missing articles, redundant clauses).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 144 RSpec/ContextWording violations across 53 spec files by prefixing
contextdescriptions withwhen/with/without. Removes the excluded cop from.rubocop_todo.yml.Changes
.rubocop_todo.yml(57 lines)Verification
rubocop --only RSpec/ContextWording: 0 offensesrubocop: 0 offenses, 0 warnings