Skip to content

config_drive: ensure the search locations are ordered alphabetically - #202

Merged
ader1990 merged 1 commit into
cloudbase:masterfrom
ader1990:config_drive_location_deterministic
Jul 30, 2026
Merged

config_drive: ensure the search locations are ordered alphabetically#202
ader1990 merged 1 commit into
cloudbase:masterfrom
ader1990:config_drive_location_deterministic

Conversation

@ader1990

@ader1990 ader1990 commented Jun 5, 2026

Copy link
Copy Markdown
Member

The internal Python implementation for the configured config drive
search locations is not deterministic.

Make it deterministic by using alphabetically sorted order.

In this case, the search order becomes:

  • type: iso, vfat
  • location: cdrom, hdd, partition

@ader1990
ader1990 marked this pull request as draft June 5, 2026 13:58
@ader1990
ader1990 force-pushed the config_drive_location_deterministic branch 2 times, most recently from 9b0e409 to ba23b10 Compare July 29, 2026 11:07
@ader1990
ader1990 marked this pull request as ready for review July 29, 2026 11:15
Comment thread cloudbaseinit/metadata/services/baseconfigdrive.py Outdated
Comment thread cloudbaseinit/constant.py Outdated
@ader1990
ader1990 force-pushed the config_drive_location_deterministic branch 2 times, most recently from 8dbb93f to f2af3b5 Compare July 30, 2026 07:14
@petrutlucian94

Copy link
Copy Markdown
Member

Let's add Fixes: https://github.com/cloudbase/cloudbase-init/issues/200 to the PR description.

Comment thread cloudbaseinit/constant.py Outdated
The internal Python implementation for the configured config drive
search locations is not deterministic.

Make it deterministic by using alphabetically sorted order.

In this case, the search order becomes:

  - type: iso, vfat
  - location: cdrom, hdd, partition

Change-Id: I622700c9408d3acee6d44eabfd73c662df7e7cfd
Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@ader1990
ader1990 force-pushed the config_drive_location_deterministic branch from f2af3b5 to 0e31866 Compare July 30, 2026 10:16
@ader1990
ader1990 merged commit ddb684e into cloudbase:master Jul 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants