fix: 🐛 Fix tags not triggering github create event - #316
Open
mckelveygreg wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 55e26c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
We are experiencing the same problem when we have a GitHub workflow triggered on a pushed tag. The workflow is not triggered when the changesets action pushes more than 3 tags. |
Author
|
@tedraykov To unblock our CI, we released a private fork with this fix in, and reference that in our action instead: - name: Create Release Pull Request
uses: <org>/changesets-action@<tag>We built it locally, so there was a |
|
Also encountering the same issue. Any mono-repo will eventually face the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been loving changesets!
However, I think I finally tracked down an issue we were having.
Our monorepo has a cloudbuild trigger listening to tags, but github doesn't create a
Createevent when more than 3 tags are created at once... which is unfortunate when we have changes in 5 of our apps...I did a local test to confirm that as long as tags are pushed one at a time, they all trigger github events.
Let me know if anything should be adjusted or if I didn't account for something!