Skip to content

Support for multiple commands in version script - #279

Open
RomanHotsiy wants to merge 1 commit into
changesets:mainfrom
RomanHotsiy:patch-1
Open

Support for multiple commands in version script#279
RomanHotsiy wants to merge 1 commit into
changesets:mainfrom
RomanHotsiy:patch-1

Conversation

@RomanHotsiy

Copy link
Copy Markdown

I'll update docs and add some more error handling if you are open to accept this PR in general.

The use case for this is to run pnpm install after changeset version

@changeset-bot

changeset-bot Bot commented Apr 3, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 49a6c09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Techn1x

Techn1x commented Aug 3, 2023

Copy link
Copy Markdown

I also needed this behaviour, I suspect the intent is that pnpm changeset version should make the necessary changes, but it does not seem to.

I got around the 1 command limitation it by adding this to my package.json scripts

"scripts: {
  "version": "changeset version && pnpm install --no-frozen-lockfile",`
}

and then setting the version arg for this action like this
version: pnpm run version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants