Skip to content

Re-enable conformance test for missing overload at runtime. #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 29, 2026
Merged

Re-enable conformance test for missing overload at runtime. #2183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions conformance/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,6 @@ _TESTS_TO_SKIP = [
"timestamps/duration_converters/get_milliseconds",

# Broken test cases which should be supported.
# TODO(issues/112): Unbound functions result in empty eval response.
"basic/functions/unbound",
"basic/functions/unbound_is_runtime_error",

# TODO(issues/97): Parse-only qualified variable lookup "x.y" with binding "x.y" or "y" within container "x" fails
"fields/qualified_identifier_resolution/qualified_ident,map_field_select,ident_with_longest_prefix_check,qualified_identifier_resolution_unchecked",
"namespace/qualified/self_eval_qualified_lookup",
Expand Down Expand Up @@ -231,12 +227,6 @@ _TESTS_TO_SKIP_LEGACY = _TESTS_TO_SKIP + [
"block_ext/basic/optional_message",
]

_TESTS_TO_SKIP_CHECKED = [
# block is a post-check optimization that inserts internal variables. The C++ type checker
# needs support for a proper optimizer for this to work.
# "block_ext",
]

_TESTS_TO_SKIP_LEGACY_DASHBOARD = [
# Future features for CEL 1.0
# TODO(issues/119): Strong typing support for enums, specified but not implemented.
Expand Down Expand Up @@ -268,15 +258,15 @@ gen_conformance_tests(
checked = True,
data = _ALL_TESTS,
modern = True,
skip_tests = _TESTS_TO_SKIP_MODERN + _TESTS_TO_SKIP_CHECKED,
skip_tests = _TESTS_TO_SKIP_MODERN,
)

gen_conformance_tests(
name = "conformance_legacy_checked",
checked = True,
data = _ALL_TESTS,
modern = False,
skip_tests = _TESTS_TO_SKIP_LEGACY + _TESTS_TO_SKIP_CHECKED,
skip_tests = _TESTS_TO_SKIP_LEGACY,
)

# select optimization is only supported for checked expressions.
Expand All @@ -286,7 +276,7 @@ gen_conformance_tests(
data = _ALL_TESTS,
modern = False,
select_opt = True,
skip_tests = _TESTS_TO_SKIP_LEGACY + _TESTS_TO_SKIP_CHECKED,
skip_tests = _TESTS_TO_SKIP_LEGACY,
)

gen_conformance_tests(
Expand All @@ -295,7 +285,7 @@ gen_conformance_tests(
data = _ALL_TESTS,
modern = True,
select_opt = True,
skip_tests = _TESTS_TO_SKIP_MODERN + _TESTS_TO_SKIP_CHECKED,
skip_tests = _TESTS_TO_SKIP_MODERN,
)

gen_conformance_tests(
Expand All @@ -304,7 +294,7 @@ gen_conformance_tests(
data = _ALL_TESTS,
enable_variadic_logical_operators = True,
modern = True,
skip_tests = _TESTS_TO_SKIP_MODERN + _TESTS_TO_SKIP_CHECKED,
skip_tests = _TESTS_TO_SKIP_MODERN,
)

gen_conformance_tests(
Expand All @@ -313,7 +303,7 @@ gen_conformance_tests(
data = _ALL_TESTS,
enable_variadic_logical_operators = True,
modern = False,
skip_tests = _TESTS_TO_SKIP_LEGACY + _TESTS_TO_SKIP_CHECKED,
skip_tests = _TESTS_TO_SKIP_LEGACY,
)

# Generates a bunch of `cc_test` whose names follow the pattern
Expand Down
Loading