[Pipe] Improve timeout diagnostics and DROP PIPE observability on dev/1.3 - #18340
Open
Caideyipi wants to merge 1 commit into
Open
[Pipe] Improve timeout diagnostics and DROP PIPE observability on dev/1.3#18340Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
…e#18297) * Improve Pipe procedure timeout diagnostics * Add pre-delete state to drop pipe procedure * Address pipe timeout diagnostic review comments * Fix pipe timeout message i18n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #18297 (
834418ed5edc62a10c45f5457a7f94a214eac67e) todev/1.3.Changes
PipeStatus.PRE_DELETEand make DROP PIPE persist the pre-delete state before notifying DataNodes and removing ConfigNode metadata.dev/1.3; master-only table-model and new i18n infrastructure are intentionally excluded.Verification
node-commonsandconfignode.PipeMetaDeSerTest,AbstractOperatePipeProcedureV2Test,DropPipeProcedureV2Test,PipeTaskInfoAutoRestartTest,PipeHeartbeatParserTest,PipeTableRespTest, andConfigPhysicalPlanSerDeTest(97 ConfigNode tests plusPipeMetaDeSerTest).git diff --cached --checkbefore commit.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
AbstractOperatePipeProcedureV2DropPipeProcedureV2PipeTaskInfoPipeHeartbeatParserPipeTaskAgentPipeStatus