Skip to content

do not send jetty version on failure to start - #13744

Draft
DaanHoogland wants to merge 1 commit into
apache:4.20from
shapeblue:ghi13666-hideJettyVersion
Draft

do not send jetty version on failure to start#13744
DaanHoogland wants to merge 1 commit into
apache:4.20from
shapeblue:ghi13666-hideJettyVersion

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #13666

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.25%. Comparing base (549daae) to head (b047bce).

Files with missing lines Patch % Lines
...om/cloud/consoleproxy/ConsoleProxyNoVNCServer.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13744      +/-   ##
============================================
- Coverage     16.26%   16.25%   -0.01%     
+ Complexity    13434    13430       -4     
============================================
  Files          5667     5667              
  Lines        500731   500737       +6     
  Branches      60803    60803              
============================================
- Hits          81455    81416      -39     
- Misses       410172   410222      +50     
+ Partials       9104     9099       -5     
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wido wido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Simple code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants