Skip to content

deal with excessive attempts on failing snapshots - #13743

Open
DaanHoogland wants to merge 2 commits into
mainfrom
ghi13454-recurringFailingSnapshots
Open

deal with excessive attempts on failing snapshots#13743
DaanHoogland wants to merge 2 commits into
mainfrom
ghi13454-recurringFailingSnapshots

Fix consecutive-failure counting bugs flagged in PR #13743 review

1cb950b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 30, 2026 in 4m 21s

Quality Gate passed

Issues
81 New issues
0 Accepted issues

Measures
0 Security Hotspots
48.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1171 in server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 83 to 64, Complexity from 26 to 14, Nesting Level from 3 to 2, Number of Variables from 30 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th95FTg1Kxg0AlXbB&open=AZ-th95FTg1Kxg0AlXbB&pullRequest=13743

Check warning on line 447 in server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th94ATg1Kxg0AlXa6&open=AZ-th94ATg1Kxg0AlXa6&pullRequest=13743

Check warning on line 314 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbF&open=AZ-th9-MTg1Kxg0AlXbF&pullRequest=13743

Check warning on line 431 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbo&open=AZ-th9-MTg1Kxg0AlXbo&pullRequest=13743

Check warning on line 319 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbK&open=AZ-th9-MTg1Kxg0AlXbK&pullRequest=13743

Check warning on line 461 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXb0&open=AZ-th9-MTg1Kxg0AlXb0&pullRequest=13743

Check warning on line 318 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbJ&open=AZ-th9-MTg1Kxg0AlXbJ&pullRequest=13743

Check warning on line 458 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbx&open=AZ-th9-MTg1Kxg0AlXbx&pullRequest=13743

Check warning on line 498 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXcF&open=AZ-th9-MTg1Kxg0AlXcF&pullRequest=13743

Check warning on line 354 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbQ&open=AZ-th9-MTg1Kxg0AlXbQ&pullRequest=13743

Check warning on line 497 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXcE&open=AZ-th9-MTg1Kxg0AlXcE&pullRequest=13743

Check warning on line 356 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbS&open=AZ-th9-MTg1Kxg0AlXbS&pullRequest=13743

Check warning on line 358 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbU&open=AZ-th9-MTg1Kxg0AlXbU&pullRequest=13743

Check warning on line 478 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXb8&open=AZ-th9-MTg1Kxg0AlXb8&pullRequest=13743

Check warning on line 494 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXcB&open=AZ-th9-MTg1Kxg0AlXcB&pullRequest=13743

Check warning on line 111 in server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th94ATg1Kxg0AlXa_&open=AZ-th94ATg1Kxg0AlXa_&pullRequest=13743

Check warning on line 489 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXcA&open=AZ-th9-MTg1Kxg0AlXcA&pullRequest=13743

Check warning on line 433 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbq&open=AZ-th9-MTg1Kxg0AlXbq&pullRequest=13743

Check warning on line 378 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXba&open=AZ-th9-MTg1Kxg0AlXba&pullRequest=13743

Check warning on line 410 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbm&open=AZ-th9-MTg1Kxg0AlXbm&pullRequest=13743

Check warning on line 444 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbs&open=AZ-th9-MTg1Kxg0AlXbs&pullRequest=13743

Check warning on line 474 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXb4&open=AZ-th9-MTg1Kxg0AlXb4&pullRequest=13743

Check warning on line 447 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbv&open=AZ-th9-MTg1Kxg0AlXbv&pullRequest=13743

Check warning on line 445 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbt&open=AZ-th9-MTg1Kxg0AlXbt&pullRequest=13743

Check warning on line 317 in server/src/test/java/com/cloud/storage/snapshot/SnapshotSchedulerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ-th9-MTg1Kxg0AlXbI&open=AZ-th9-MTg1Kxg0AlXbI&pullRequest=13743
View more details on SonarQubeCloud