[AURON #2434] Support full-data-file Iceberg changelog deletes - #2435
Open
weimingdiit wants to merge 1 commit into
Open
[AURON #2434] Support full-data-file Iceberg changelog deletes#2435weimingdiit wants to merge 1 commit into
weimingdiit wants to merge 1 commit into
Conversation
Allow native Iceberg changelog scan to handle DeletedDataFileScanTask when the task represents a DELETE operation and has no existing delete files. Keep existing support for insert changelog tasks and continue falling back for row-level deletes, position/equality deletes, update changelog tasks, mixed file formats, and delete tasks with existing deletes. Add tests for full-data-file delete changelog scans and mixed insert/delete changelog ranges. Signed-off-by: weimingdiit <weimingdiit@gmail.com>
merrily01
reviewed
Jul 29, 2026
merrily01
left a comment
merrily01
left a comment
Member
There was a problem hiding this comment.
@weimingdiit Thanks for the contribution. The implementation looks correct to me, just a few comments inline.
| test("iceberg changelog scan falls back when delete changes exist") { | ||
| withTable("local.db.t_changelog_delete") { | ||
| withTempView("t_changelog_delete_changes") { | ||
| test("iceberg native scan supports mixed insert and full-data-file delete changelog scan") { |
Member
There was a problem hiding this comment.
This replaces the previous falls back when delete changes exist test, which covered row-level deletes. Could we keep a dedicated fallback test (e.g. non-partitioned table with a position delete, or a DeletedDataFileScanTask with non-empty existingDeletes())? It would help guard against regressions on the row-level delete / update paths.
| deletesEmpty(added.deletes()) => | ||
| Some(NativeChangelogDataFileTask(added.file(), added.start(), added.length(), added)) | ||
| case deleted: DeletedDataFileScanTask | ||
| if deleted.operation() == ChangelogOperation.DELETE && |
Member
There was a problem hiding this comment.
Nit: deleted.operation() == ChangelogOperation.DELETE is always true. How about dropping it or adding a comment for clarity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2434
Rationale for this change
Auron native Iceberg changelog scan currently supports insert-only changelog tasks.
Full-data-file delete changelog tasks can be executed natively without row-level delete-file handling. Auron can scan the deleted data file directly and materialize changelog metadata from the Iceberg changelog task.
Supporting this case improves native Iceberg changelog scan coverage while keeping more complex delete and update semantics on Spark's reader.
What changes are included in this PR?
Allows native Iceberg changelog scan to accept
DeletedDataFileScanTaskwhen:DELETEexistingDeletes()is emptyKeeps existing native support for
AddedRowsScanTaskwhen:INSERTdeletes()is emptyKeeps fallback behavior for unsupported changelog tasks, including row-level deletes, position/equality deletes, update changelog tasks, mixed file formats, and delete tasks with existing delete files.
Adds coverage for:
Are there any user-facing changes?
No user-facing API changes. More Iceberg changelog scans can now be executed natively by Auron.
How was this patch tested?
UT.