fix: expose conclusion as a root action output - #1549
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unified entrypoint sets
core.setOutput("conclusion", claudeResult.conclusion), but the rootaction.ymldoes not declare or forward that output. Callers therefore cannot reliably consumesteps.<id>.outputs.conclusion, even though the internalrunstep produces it.This adds the missing public output mapping:
base-action/action.ymlalready exposes the same output, so this also makes the root and standalone action interfaces consistent.Regression coverage
Adds a focused metadata test that checks the root output forwards
steps.run.outputs.conclusion. This catches future drift between outputs set by the entrypoint and outputs exposed by the composite action.Verification
bun test: 805 pass, 0 failbun run typecheck: cleanbunx prettier --check action.yml test/action-metadata.test.ts: cleangit diff --check: clean