fix(aws): async _prepare_request blocks eventloop - #1774
Open
retornam wants to merge 1 commit into
Open
Conversation
This fixes [issues/1170][1] where AsyncAnthropicBedrock performs AWS credentialresolution and SigV4 signing synchronously on the event-loop thread. This change fixes `_prepare_request` to wrap the blocking call so it runs off the event loop thread. [1]: anthropics#1770 Signed-off-by: Raymond Etornam <retornam@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues/1170 where AsyncAnthropicBedrock performs AWS credentialresolution and SigV4 signing synchronously on the event-loop thread.
This change fixes
_prepare_requestto wrap the blocking call so it runs off the event loop thread.