Skip to content

fix: return 404 for unknown advisory IDs #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w3lld1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: return 404 for unknown advisory IDs #2397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vulnerabilities/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2926,7 +2926,10 @@ def to_dict(self):

class AdvisoryV2QuerySet(BaseQuerySet):
def latest_for_avid(self, avid: str):
return self.get(avid=avid, is_latest=True)
try:
return self.get(avid=avid, is_latest=True)
except self.model.DoesNotExist:
return None

def latest_per_avid(self):
return self.filter(is_latest=True)
Expand Down
8 changes: 8 additions & 0 deletions vulnerabilities/tests/test_same_avid_different_content_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ def test_latest_for_avid_returns_latest_by_date_collected(
assert result.id != older.id


@pytest.mark.django_db
def test_latest_for_avid_returns_none_when_advisory_does_not_exist(django_assert_num_queries):
with django_assert_num_queries(1):
result = AdvisoryV2.objects.latest_for_avid("pysec/PYSEC-3000-0")

assert result is None


@pytest.mark.django_db
def test_latest_for_avid_tie_breaks_by_id(advisory_factory, django_assert_num_queries):
avid = "source/ADV-2"
Expand Down