Skip to content

https_client: log recoverable connection errors at INFO instead of WARNING #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrObvious wants to merge 3 commits into from
Closed

https_client: log recoverable connection errors at INFO instead of WARNING #211

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3d30f4
https_client: trigger connection reset timer on HTTP/2 and send/recv …
MrObvious Jul 29, 2026
9d7dc61
https_client: log recoverable connection errors at INFO instead of WA…
MrObvious Jul 29, 2026
c4d6b4a
Merge branch 'master' into patch-2-log-levels
aarond10 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/https_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,12 @@ static void https_fetch_ctx_init(https_client_t *client,
if (multi_code != CURLM_OK) {
ELOG_REQ("curl_multi_add_handle error %d: %s", multi_code, curl_multi_strerror(multi_code));
if (multi_code == CURLM_ABORTED_BY_CALLBACK) {
WLOG_REQ("Resetting HTTPS client to recover from faulty state!");
WLOG_REQ("Resetting HTTPS client to




from faulty state!");
https_client_reset(client);
} else {
https_fetch_ctx_cleanup(client, NULL, client->fetches, -1); // dropping current failed request
Expand All @@ -347,6 +352,11 @@ static int https_fetch_ctx_process_response(https_client_t *client,
long long_resp = 0;
char *str_resp = NULL;
int faulty_response = 1;
// Set for connection-reuse hiccups that the reset-timer path already
// recovers from automatically - these are routine, not warning-worthy,
// and logging them at WARNING just spams flash-constrained routers with
// an expected condition. Genuinely unexpected failures still log at WARNING.
int recoverable = 0;

switch (curl_result_code) {
case CURLE_OK:
Expand All @@ -363,11 +373,17 @@ static int https_fetch_ctx_process_response(https_client_t *client,
case CURLE_SEND_ERROR:
// These all indicate a stale/broken (often reused HTTP/2) connection,
// not a one-off content error - same recovery path as a timeout.
recoverable = 1;
if (!ev_is_active(&client->reset_timer)) {
ILOG_REQ("Client reset timer started");
ev_timer_start(client->loop, &client->reset_timer);
}
__attribute__((fallthrough));
ILOG_REQ("curl request failed with %d: %s (recoverable, reset timer will recycle connection)",
curl_result_code, curl_easy_strerror(curl_result_code));
if (ctx->curl_errbuf[0] != 0) {
ILOG_REQ("curl error message: %s", ctx->curl_errbuf);
}
break;
default:
WLOG_REQ("curl request failed with %d: %s", curl_result_code, curl_easy_strerror(curl_result_code));
if (ctx->curl_errbuf[0] != 0) {
Expand All @@ -385,8 +401,8 @@ static int https_fetch_ctx_process_response(https_client_t *client,
curl_off_t uploaded_bytes = 0;
if (curl_easy_getinfo(ctx->curl, CURLINFO_SIZE_UPLOAD_T, &uploaded_bytes) == CURLE_OK &&
uploaded_bytes > 0) {
WLOG_REQ("Connecting and sending request to resolver was successful, "
"but no response was sent back");
LOG(recoverable ? LOG_INFO : LOG_WARNING, "%04hX: Connecting and sending request to resolver was successful, "
"but no response was sent back", ctx->id);
if (client->opt->use_http_version == 1) {
// for example Unbound DoH servers does not support HTTP/1.x, only HTTP/2
WLOG("Resolver may not support current HTTP/%s protocol version",
Expand All @@ -398,7 +414,7 @@ static int https_fetch_ctx_process_response(https_client_t *client,
// that have been opened a long time ago (if CURLOPT_MAXAGE_CONN can not be increased
// it is 118 seconds)
// also: when no internet connection, this floods the log for every failed request
WLOG_REQ("No response (probably connection has been closed or timed out)");
LOG(recoverable ? LOG_INFO : LOG_WARNING, "%04hX: No response (probably connection has been closed or timed out)", ctx->id);
}
} else {
WLOG_REQ("curl response code: %d, content length: %zu", long_resp, ctx->buflen);
Expand Down
Loading