fix: use resolved LLM key for PageIndex - #209
Draft
wachiravit-thitagran wants to merge 1 commit into
Draft
Conversation
|
It looks like this is a related issue #205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLM_API_KEY, base URL, headers, and timeout through PageIndexllm_paramsOPENAI_API_KEYRoot cause
PageIndex validates provider-specific process environment variables during local client construction, before its per-call
llm_paramsare used. OpenKB stores the UI key asLLM_API_KEYand resolves it into an isolated request bundle, so OpenAI-compatible models failed withOPENAI_API_KEYmissing even though the UI key was configured.Validation
pytest tests/test_indexer.py tests/test_add_command.py tests/test_api.py -q(224 passed)ruff checkandruff format --checkon changed filesmypy openkb/cli.py openkb/indexer.pygit diff --checkWarning
AI-generated code: This fix was generated by GPT-5.6 Sol.