fix: use latest UI LLM settings for ingest - #208
Closed
wachiravit-thitagran wants to merge 1 commit into
Closed
Conversation
wachiravit-thitagran
force-pushed
the
agent/fix-latest-ui-llm-settings
branch
from
July 29, 2026 09:35
6763214 to
62877ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The Workbench settings endpoints persisted changes correctly, but
/api/v1/addcaptured a credential bundle once per upload request and the watcher captured one once at startup. Later UI saves therefore did not affect already-running multi-file uploads or watchers. Local PageIndex also validated only provider environment variables before its per-call settings were applied.Impact
Each file ingest now reads the latest persisted UI settings immediately before processing, including files discovered by an already-running watcher. Concurrent KBs retain per-request credential isolation.
Validation
pytest tests/test_indexer.py tests/test_add_command.py tests/test_api.py tests/test_watch_service.py::test_worker_does_not_reuse_bundle_captured_at_watcher_start -q- 226 passedruff checkandruff format --checkon changed filesmypy openkb/api.py openkb/api_helpers.py openkb/cli.py openkb/indexer.py openkb/watch_service.pygit diff --check