Migrate remaining MockMvc tests to RestTestClient - #702
Closed
rjayasinghe wants to merge 1 commit into
Closed
Conversation
Convert GenreHierarchyTest and FeatureTogglesIT from MockMvc to RestTestClient, matching the pattern already used in CatalogServiceITest: - @AutoConfigureMockMvc -> @AutoConfigureRestTestClient - MockMvc -> RestTestClient - client.perform(get(uri)) -> client.get().uri(uri).exchange() - .andExpect(status().isOk()) -> .expectStatus().isOk() - jsonPath(p).value(v) -> .expectBody().jsonPath(p).isEqualTo(v) - jsonPath(p).doesNotExist() -> .jsonPath(p).doesNotExist() - Hamcrest containsString matchers -> AssertJ value(Class, Consumer) RestTestClient is now the only servlet test client used across the integration/service tests.
Contributor
Author
|
I understood that we want to keep both, MockMVC and RestTestClient in the sample. Thus, I close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates the two remaining MockMvc-based tests to
RestTestClient, matching the pattern already used inCatalogServiceITest:srv/.../GenreHierarchyTest.javaintegration-tests/.../FeatureTogglesIT.javaRestTestClientis now the only servlet test client used across the integration/service tests; no more MockMvc usage remains.Changes
@AutoConfigureMockMvc→@AutoConfigureRestTestClient,MockMvc→RestTestClientclient.perform(get(uri))→client.get().uri(uri).exchange().andExpect(status().isOk())→.expectStatus().isOk().andExpect(jsonPath(p).value(v))→.expectBody().jsonPath(p).isEqualTo(v)(works for both string and numeric values, incl. the$countscalar).andExpect(jsonPath(p).doesNotExist())→.jsonPath(p).doesNotExist()containsStringmatchers → AssertJvalue(Class, Consumer)(consistent with the reference test)throws Exception; keptUriComponentsBuilder/URIhandling infilterExpandLevelsNo production code changed.
Testing
GenreHierarchyTest— 11/11 passFeatureTogglesIT— 3/3 pass (verified with the MTX sidecar running onlocalhost:4005, as required by the test's existing precondition)