prepare for the 6.2.0 release - #276
Open
kevinushey wants to merge 4 commits into
Open
Conversation
Consolidate the NEWS entries for this cycle: three of them described intermediate states that later commits superseded, and contradicted the entries above them -- configure no longer probes for an Rtools TBB, and the tbb.dll stub is gone. Also correct the flags documentation, which claimed LdFlags() emits nothing on macOS; that stopped being true in 5.1.8, and this release adds an -rpath there. Drop patches/windows_arm64.diff, which patches files removed with the make-based TBB in 6.0.0 and whose one remaining hunk is now upstream. Exclude .worktrees from the build: R CMD build was sweeping local worktrees into the tarball, 1741 of its 2193 files.
RcppParallel 6.1.1 currently fails to install on r-release-macos-x86_64, which is the most consequential thing 6.2.0 fixes. The NEWS entry framed it as affecting code that includes the header; src/tbb.cpp includes it via RcppParallel/TBB.h, so it broke our own compilation too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release preparation for RcppParallel 6.2.0. The functional work landed
earlier in #267-#275; this is the packaging, NEWS, and documentation pass
on top of it.
Changes
.Rbuildignore: exclude.worktrees.R CMD buildwas sweeping localgit worktrees into the source tarball -- 1741 of its 2193 files, 3.9 MB vs
710 KB. This would have failed the CRAN submission.
NEWS.md: consolidate the cycle into a6.2.0section. Three entriesdescribed intermediate states that later commits superseded, and
contradicted the entries above them: one said configure prefers an Rtools
TBB when it is oneTBB (it no longer probes for one at all), and two
described the
tbb.dllstub as present (it was removed in build the bundled onetbb as a shared library on windows #274).DESCRIPTION:6.1.1.9000->6.2.0.R/flags.R,man/flags.Rd: the details section claimedLdFlags()emits nothing on macOS. That stopped being true in 5.1.8, and this release
adds an
-rpaththere, so the text now describes each platform.R/tbb.R: correct the comment on theTBB_ENABLEDguard -- it referredto a tinythread build outcome that require cmake on all platforms; tbb is always enabled #275 removed. The guard itself stays.
patches/windows_arm64.diff: delete. It patchessrc/tbb/build/Makefile.*,removed with the make-based TBB in 6.0.0, and its one live hunk is now
upstream in oneTBB 2022. It is the only patch that fails a reverse-apply
check against the vendored tree.
.github/workflows/R-CMD-check.yaml: fix two comments claiming R 4.2 isthe only Windows config that builds the bundled oneTBB. Since require cmake on all platforms; tbb is always enabled #275, every
Windows config does.
cran-comments.md: new, for the submission.Verification
R CMD check --as-cranonRcppParallel_6.2.0.tar.gz: 1 NOTE, theincoming-feasibility days-since-last-update note. (An earlier
non-portable-flags WARNING traced to a local
~/.R/Makevars, not thepackage.)
downstreamlink checks.
(rtools42, rtools45, rtools45-aarch64), confirming the "cmake required
everywhere" change in require cmake on all platforms; tbb is always enabled #275 does not strand Windows users.
(run 30473955617) --
the configuration that motivated the Windows rework. The version guard
confirms it tested this build rather than CRAN's.
Outstanding
cran-comments.mdhas aTODOfor the revdepcheck section; the cloud jobagainst 6.2.0 is still running.