feat(ui): prototype static spaces sidebar - #4060
Draft
puemos wants to merge 7 commits into
Draft
Conversation
Generated-By: PostHog Code Task-Id: 7698cad8-55a1-4e67-9657-91ce3e8f0a52
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
…ace toggle Generated-By: PostHog Code Task-Id: 7698cad8-55a1-4e67-9657-91ce3e8f0a52
Generated-By: PostHog Code Task-Id: 7698cad8-55a1-4e67-9657-91ce3e8f0a52
Generated-By: PostHog Code Task-Id: 7698cad8-55a1-4e67-9657-91ce3e8f0a52
… language Drops the Home/Tasks/Inbox rows (the ChannelNav icon row already covers them), replaces the per-space tab strip with the channel header's own tabs, and makes space rows behave like the rest of the sidebar: the row opens the space, the disclosure caret folds it, the star (hover-revealed) pins. The All spaces list becomes a section-labelled directory whose rows open the space instead of silently pinning it, with a New space entry and the ChannelsFab restored so the static layout keeps a create affordance. Generated-By: PostHog Code Task-Id: 0331ac58-0a1c-4b4e-b884-2ff7d8e71986
Contributor
Author
|
Pushed a design pass over the prototype (e9de196): removed the Home/Tasks/Inbox rows (the icon nav already covers them), dropped the per-space tab strip in favour of the channel header's existing tabs, made space rows open-on-click with a proper disclosure caret and hover-revealed pin star, turned All spaces into a section-labelled directory whose rows open the space (clicking used to silently pin), and restored a create path in this layout via the FAB plus a New space row. Details in the commit message; Created with PostHog Code |
…rectory Sidebar feedback round: a space row is now a single click target that folds its task list (no separate caret hover zone); the hover gear on the right opens the space in the main view, and #me's lock moves into that same trailing well. The header regains a tab strip under the channels layout (Feed, Context, Loops, Artifacts, Recents) as the breadcrumb's trailing slot, since the sidebar no longer carries page links. A My-tasks switch above the pinned list narrows every space's tasks to the viewer's own via the exported core ownership rule. All spaces docks at the bottom, sheds its cube for a caret aligned with the space rows, and opens upward to a capped, scrollable height. Generated-By: PostHog Code Task-Id: 0331ac58-0a1c-4b4e-b884-2ff7d8e71986
…ce task windows Sidebar feedback round three. The space header swaps its trailing button strip for quill line tabs (Feed/Context/Loops/Artifacts/Recents) on their own row under the space name, matching Inbox/Activity; the header bar grows via min-height so single-row breadcrumbs are unchanged. Each space's task list leads with a "New session" row, shows a five-row scroll window with View all pinned below, and its task rows are draggable into the Command Center with the same text/x-task-id payload as the code sidebar. Pinned spaces reorder by dragging their header row (dnd-kit sortable, #me fixed first, order persisted in the sidebar store). The filter row is labeled "Spaces" and its switch explains itself in a tooltip. Generated-By: PostHog Code Task-Id: 0331ac58-0a1c-4b4e-b884-2ff7d8e71986
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Prototype for a new sidebar design: get rid of the moving (sliding) sidenav and replace it with a single static nav where every space shows its tasks beneath it, and where spaces only appear once a user adds them to their sidebar (by adding an existing space or creating a new one) instead of listing all spaces by default.
Changes
code-spaces-layoutflag,ChannelsSidebarnow renders a staticSpacesSidebarNavinstead of the 200%-width panes slider (theChannelPanestrack, swipe gesture, and route-scoping side effects are removed from the shell).SpacesSidebarNav: Home / Tasks / Inbox nav rows (Inbox has a "+" affordance), then every pinned (starred) space with its tasks expanded inline beneath it, an "Add space" menu (finding an existing space stars it; "New space" opens the create modal), and a pinned-agents placeholder section.spacesSidebarStore).useChannelItems+ChannelItemRow, so a space's tasks render identically to the old channel pane.Screenshots to follow once run against a live backend.
How did you test this?
pnpm --filter @posthog/ui test— all 289 files / 2443 tests pass (rewroteChannelsSidebar.test.tsxfor the static nav; kept Archived-row and tracking coverage).pnpm --filter @posthog/ui typecheck— clean.pnpm biome check packages/ui/src— clean.Automatic notifications
Created with PostHog Code