fix(spaces): hold sidebar peek open while space Filter menu is open - #3972
Draft
dmarticus wants to merge 1 commit into
Draft
fix(spaces): hold sidebar peek open while space Filter menu is open#3972dmarticus wants to merge 1 commit into
dmarticus wants to merge 1 commit into
Conversation
The space sidebar's "Recent" Filter dropdown didn't hold the sidebar's hover-peek open while it was open, unlike every other sidebar-spawned menu (TasksHeader, ProjectSwitcher) which do via useHoldSidebarPeek(). When the sidebar is only hover-peeked (not pinned), moving the pointer toward the opened Filter menu let the panel collapse and stranded the dropdown's portal anchor, so filter conditions couldn't be picked. Wire the same peek-hold as the other menus. Generated-By: PostHog Code Task-Id: e2e30680-93e8-4ff2-8747-9f6a3bed2b68
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Spaces/Channels layout, the space sidebar's "Recent" list has a Filter control (Created by / Status). When the left sidebar is only hover-peeked (collapsed, not pinned), opening that Filter menu and moving the pointer toward it collapses the peeked panel and strands the dropdown's portal anchor — so you can't actually pick a filter condition. Reported from a Slack thread.
Changes
Wire
ChannelSidebar's FilterDropdownMenutouseHoldSidebarPeek()viaonOpenChange, holding the peek open while the menu is open. This matches the pattern already used by every other sidebar-spawned menu (TasksHeader,ProjectSwitcher) since the peek-hold fix landed; the space sidebar's filter dropdown was the one that missed it when the flag-gated Spaces layout was added.How did you test this?
pnpm --filter @posthog/ui typecheck— cleanbiome linton the changed file — cleanpnpm --filter @posthog/ui test— 2377 passed (incl.sidebarPeekStore/useHoldSidebarPeeksuites)Not manually verified in the running app.
Automatic notifications
Created with PostHog from a Slack thread