Skip to content

fix(loops): group loops by visibility - #3957

Open
benben wants to merge 1 commit into
mainfrom
fix/loop-visibility-tabs
Open

fix(loops): group loops by visibility#3957
benben wants to merge 1 commit into
mainfrom
fix/loop-visibility-tabs

Conversation

@benben

@benben benben commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • group personal and team loops by their visibility instead of creator ownership
  • move team-visible loops created by the current user into Team loops
  • remove the current-user request that was only needed for ownership grouping
  • add regression coverage for team loops created by the signed-in user

Testing

  • pnpm exec vitest run src/features/loops/components/LoopsListView.test.tsx (4 passed)
  • pnpm exec biome check src/features/loops/components/LoopsListView.tsx src/features/loops/components/LoopsListView.test.tsx
  • full typecheck/pre-commit hook is currently blocked by the unrelated missing typebox dependency in @posthog/harness

@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

✨ Submitted to Merge by @benben. It will be added to the merge queue once all branch protection rules pass and there are no merge conflicts with the target branch. See more details here.

@benben
benben requested a review from a team July 29, 2026 15:18
@benben
benben enabled auto-merge (squash) July 29, 2026 15:18
@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit f24d3cf.

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(loops): group loops by visibility" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant