feat: budgeted console formatter (inspect builtin)

[edusperoni]

Description

Android mirror of NativeScript/ios#416. Stacked on #1990 (feat/primordials) — review only the last commit.

Replaces the console's logcat formatting pipeline — which could hang the app on a single console.log — with internal/inspect.js, a budgeted util.inspect-lite built on primordials. The DevTools path (inspector formats raw values itself) is untouched.

The problem

• transformJSObject fell back to JSON.stringify(obj, replacer, 2) with no depth or size limit — logging a store/component tree serialized everything reachable.
• The replacer's seen array made cycle tracking O(n²) and never popped on subtree exit, so shared acyclic references falsely printed [Circular].
• The hand-rolled array printer recursed with no depth limit and only caught an array containing itself.
• JSON.stringify invokes getters and toJSON — a log line could execute arbitrary user code.
• console.dir had its own duplicate dump with the same issues.

The fix (inspect.js, ported verbatim from iOS — function-body builtin, primordials-clean):

• Budgets everywhere: depth 2 (dir uses 4), 100 entries per collection, 10k chars per string, 16KB hard cap with an explicit truncation marker.
• Correct cycles: ancestor Set (enter/exit) — true cycles say [Circular], diamonds print normally.
• Getters never invoked ([Getter]/[Setter] tags), with two guarded exceptions: error.stack, and custom toString overrides — NativeScript core's ViewBase/Observable convention (Button(42)) keeps working, detected via descriptors and invoked guarded + capped.
• Tamper-immune: brands via captured Object.prototype.toString, Map/Set walked through captured iterator next, sizes via captured accessor getters.
• Exposed as the internal __inspect global.

binding.getNativeWrapperHint — the Android-specific piece. Java-backed objects render as short hints instead of having their native-backed graphs walked: [java.lang.Object], [java.util.ArrayList], [package java.lang]; Java classes print [Function: java.lang.Object] via their existing SetClassName. Detection reads private symbols and internal fields only — no JNI, no JS execution, cannot throw. Two hazards handled along the way:

• InternalFieldCount() == 2 alone false-positives on typed arrays/ArrayBuffers (V8 gives them the same embedder-field count); the hint additionally requires the field to hold a real External.
• Package objects expose their children as native data properties whose getters getOwnPropertyDescriptor would invoke — console.log(java) would have materialized every class in every package. Packages now carry a private marker and short-circuit to [package …].

Deleted: smart-stringify.js, GetSmartJSONStringifyFunction, JsonStringifyObject (console was its only caller), transformJSObject, the array printer, and dir's duplicate dump. If the formatter ever fails to initialize, logging degrades to ToDetailString.

Output changes to be aware of: logs now look like Node's inspect output ({ a: 1, self: [Circular] }, Map(2) { … }, truncation markers) instead of pretty-printed JSON; console.dir keeps its dump markers but prints one budgeted rendering at depth 4; Java arrays render as a hint instead of being walked.

Related Pull Requests

• feat: budgeted console formatter (inspect builtin) ios#416 (iOS counterpart)
• feat: Node-style primordials for runtime builtins #1990 (base)

Does your pull request have unit tests?

Yes — 14 new device specs (tests/testInspect.js): cycles vs diamonds, caps/truncation, getter non-invocation, native-wrapper hints on real Java objects, tampered-prototype formatting, and a bounded-time regression (console.log of a ~5000-node cyclic graph). Full suite: 627 specs, 0 failures (613 baseline + 14).

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 726d3cd6-0115-45c2-83d2-9ead58098015

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}