mesh-2925: fix sonar - #268
Merged
Merged
Conversation
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Pull request overview
This PR updates CI Sonar scanning in GitHub Actions workflows by replacing the hand-rolled SonarScanner download/execution steps with the maintained SonarSource/sonarqube-scan-action, and renaming the pre-scan step to “prepare sonar reports”.
Changes:
- Removed
actions/setup-javaand manualsonar-scanner-cliprovisioning steps from CI workflows. - Added a “prepare sonar reports” step and switched Sonar execution to
SonarSource/sonarqube-scan-action. - Applied the same Sonar workflow changes to both PR and develop-merge pipelines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/pull-request.yml | Switch PR workflow Sonar scanning from manual scanner provisioning to SonarSource scan action; add “prepare sonar reports” step. |
| .github/workflows/merge-develop.yml | Switch develop branch workflow Sonar scanning from manual scanner provisioning to SonarSource scan action; add “prepare sonar reports” step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
63
| - name: prepare sonar reports | ||
| if: success() || failure() | ||
| run: | | ||
| export SONAR_VERSION="5.0.1.3006" | ||
| wget -q --max-redirect=0 "https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${SONAR_VERSION}.zip" -O sonar-scanner.zip | ||
| unzip -q ./sonar-scanner.zip | ||
| mv ./sonar-scanner-${SONAR_VERSION} ./sonar-scanner | ||
| cat sonar-project.properties | ||
| scripts/sonar_tests.py |
Comment on lines
+142
to
146
| - name: prepare sonar reports | ||
| if: success() || failure() | ||
| run: | | ||
| export SONAR_VERSION="5.0.1.3006" | ||
| wget -q --max-redirect=0 "https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${SONAR_VERSION}.zip" -O sonar-scanner.zip | ||
| unzip -q ./sonar-scanner.zip | ||
| mv ./sonar-scanner-${SONAR_VERSION} ./sonar-scanner | ||
| cat sonar-project.properties | ||
| scripts/sonar_tests.py |
johnwilliams57-nhs
previously approved these changes
Jul 29, 2026
johnwilliams57-nhs
approved these changes
Jul 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.