Fix MSSQL Docker discovery on IPv4 loopback - #279
Open
HerrLiljegren wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This surfaced while using sqlit to auto-connect to an Aspire-managed SQL Server container. Docker discovery found the mapped port and credentials, but
localhostresolved to::1while SQL Server was published on IPv4 loopback, so the connection failed.The change is MSSQL-specific. Manual connections and other providers are unchanged.
Tests
Implementation and review were AI-assisted; the final diff and test evidence were manually reviewed.