docs(workflow): learnings from the docs-sync repro gate - #4829
Open
iscekic wants to merge 2 commits into
Open
Conversation
- docs-sync edit-pass repro rounds need state reset between runs (edit.mjs short-circuits on leftover summaries) - background_process mangles inline ruby/perl one-liners; use a runner script file instead
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed two new workflow-learnings markdown files with no code, images, or logic changes; no issues identified. Files Reviewed (2 files)
Reviewed by claude-sonnet-5 · Input: 12 · Output: 1.5K · Cached: 196.2K Review guidance: REVIEW.md from base branch |
Contributor
Author
|
(bot) @kilocode-bot please review the latest head (7d6c470). The diff against main is unchanged (still the two learnings files); the branch was merged up with origin/main only. |
Contributor
|
Re-reviewed at 7d6c470 — since the diff against main is unchanged (still just the two learnings files, only a merge-up with origin/main), the prior review stands: no issues found, docs-only change, safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two workflow learnings recorded by the docs-sync CLI section's repro gate, committed so future
workflow runs inherit them (
.kilo_workflow/learnings/is the workflow's shared memory — see.kilo_workflow/WORKFLOW.md):docs-sync-repro-round-state-reset.md— anedit.mjsrepro round must reset state betweenruns: it short-circuits on leftover
docs-sync-out/summaries and a pre-dirtypackages/kilo-docs, silently faking "work done".background-process-inline-quote-mangling.md—background_processmangles inlineruby/perl one-liners in the command string; write a runner script file and invoke that instead.
Docs-only, exactly these two files, nothing else. Companion (code) PR:
Kilo-Org/kilocode#12605 — the docs-sync bot fix these learnings came from.
Verification
.kilo_workflow/learnings/, no code pathstouched. Content was validated during the docs-sync repro gate itself (both entries record
blockers that were hit and resolved there).
Visual Changes
N/A
Reviewer Notes
Cross-link: Kilo-Org/kilocode#12605