Use LibSSH v1 for the tests - #72
Conversation
| JULIA_NUM_THREADS = "1" | ||
| end | ||
| run(addenv(`$cmd $sshtestfile`, "JULIA_NUM_THREADS" => "1")) | ||
| run(`$cmd $sshtestfile`) |
There was a problem hiding this comment.
Do you actually need to run this in a separate process?
There was a problem hiding this comment.
Good question, I actually don't think so 🤔 IIRC it was meant to be run as a standalone file in Distributed because it wasn't possible to run automatically with a properly configured SSH server.
There was a problem hiding this comment.
I thought it was to force single-threaded julia, which isn't needed anymore
There was a problem hiding this comment.
Yeah probably also that. Looks like it works 👍
EDIT: or not...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 88.64% 88.78% +0.13%
==========================================
Files 13 13
Lines 2273 2273
==========================================
+ Hits 2015 2018 +3
+ Misses 258 255 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
v1 is threadsafe so the SSH tests don't need to be run single-threaded anymore. The SSH tests spun up a lot of workers so some hardcoded worker IDs elsewhere needed to be fixed.
2 participants
v1 is threadsafe so the SSH tests don't need to be run single-threaded anymore.