Skip to content

Remove custom (de)serializers from the DashPattern and BoxCorners TaggedValue variants - #4394

Merged
Keavon merged 1 commit into
masterfrom
replace-list-newtype-tagged-values-with-f64array
Aug 2, 2026
Merged

Remove custom (de)serializers from the DashPattern and BoxCorners TaggedValue variants#4394
Keavon merged 1 commit into
masterfrom
replace-list-newtype-tagged-values-with-f64array

Conversation

@Keavon

@Keavon Keavon commented Aug 2, 2026

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/libraries/vector-types/src/vector/style.rs Outdated
@Keavon
Keavon force-pushed the replace-list-newtype-tagged-values-with-f64array branch from b0e14b7 to 29548e4 Compare August 2, 2026 07:30

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon changed the title Replace the DashPattern and BoxCorners TaggedValue variants with bare F64Array values Remove custom (de)serializers from the DashPattern and BoxCorners TaggedValue variants Aug 2, 2026
@Keavon
Keavon merged commit e52a442 into master Aug 2, 2026
11 checks passed
@Keavon
Keavon deleted the replace-list-newtype-tagged-values-with-f64array branch August 2, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant