Skip to content

docs(alm): add ui samples - #14459

Merged
amcolin merged 12 commits into
GoogleCloudPlatform:mainfrom
QMeng:alm-ui-integration
Jul 30, 2026
Merged

docs(alm): add ui samples#14459
amcolin merged 12 commits into
GoogleCloudPlatform:mainfrom
QMeng:alm-ui-integration

Conversation

@QMeng

@QMeng QMeng commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

@QMeng
QMeng requested review from a team as code owners July 24, 2026 21:41
@snippet-bot

snippet-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Flask-based UI example for Apigee API generation and deployment, along with its Docker configuration and static assets. Feedback highlights a critical command injection vulnerability in app.py due to unsafe shell execution of user-controlled input. Additionally, several files contain redundant or entirely commented-out code—including active_app_backup.py, app2.py, and sections within app.py and the Dockerfile—which should be removed to maintain code cleanliness.

Comment thread alm/ui-examples/app.py Outdated
Comment thread alm/ui-examples/app.py Outdated
Comment thread alm/ui-examples/Dockerfile Outdated
Comment thread alm/ui-examples/active_app_backup.py Outdated
Comment thread alm/ui-examples/app2.py Outdated
@QMeng

QMeng commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

ALM isn't in Snippet-Bot's official product list yet, but alm_ui_sample is the correct intended tag for this product snippet.

@QMeng

QMeng commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Can a maintainer please add the snippet-bot:no-prefix-req label? ALM isn't registered as a product prefix yet.

@QMeng
QMeng requested a review from a team as a code owner July 27, 2026 13:12
@QMeng

QMeng commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@GoogleCloudPlatform/python-samples-reviewers Could someone please take a look? I've addressed the formatting, security, and license feedback from the automated bots.

@XrossFox XrossFox added the snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement label Jul 29, 2026

@XrossFox XrossFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions here, also, is there a buganizer number for this PR?.

Comment thread alm/ui-examples/read-me.txt Outdated
Comment thread alm/ui-examples/read-me.txt Outdated
Comment thread alm/ui-examples/read-me.txt Outdated
@QMeng

QMeng commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

I have a few questions here, also, is there a buganizer number for this PR?.

Thanks for the review! Addressed all the comments.

b/538721412 is the buganizer.

@QMeng
QMeng requested a review from XrossFox July 29, 2026 20:08

@XrossFox XrossFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it looks like you have a bunch of linting issues, now that the workflows are running. One last thing, since we dont have pipelines for automated testing anymore, we made a requirement to attach execution screenshot of the code sample to make sure it is running.

@QMeng

QMeng commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@QMeng
QMeng requested a review from XrossFox July 30, 2026 13:59
@arjayaraj

Copy link
Copy Markdown

requested screenshots for the reviewer:

@QMeng

QMeng commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Lint errors fixed as well. PTAL!

@XrossFox XrossFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen the screnshots. Linter is now passing. LGTM.

@QMeng

QMeng commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@XrossFox Thanks for reviewing! Could you please formally submit an Approving review in GitHub and merge the PR when ready? (I don't have merge permissions on this repository).

@amcolin
amcolin merged commit aefdff9 into GoogleCloudPlatform:main Jul 30, 2026
10 checks passed
@QMeng
QMeng deleted the alm-ui-integration branch July 30, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples. snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants