Skip to content

refactor(gae): remove region tags from datastore inequality filters #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kef131 merged 1 commit into from
Jul 30, 2026
Merged

refactor(gae): remove region tags from datastore inequality filters #10319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions appengine-java8/datastore/src/test/java/com/example/appengine/QueriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@ public void queryRestrictions_compositeFilter_returnsMatchedEntities() throws Ex
// Act
long minBirthYear = 1940;
long maxBirthYear = 1980;
// [START gae_java8_datastore_inequality_filters_one_property_valid_1]
Filter birthYearMinFilter =
new FilterPredicate("birthYear", FilterOperator.GREATER_THAN_OR_EQUAL, minBirthYear);

Expand All @@ -486,7 +485,6 @@ public void queryRestrictions_compositeFilter_returnsMatchedEntities() throws Ex
CompositeFilterOperator.and(birthYearMinFilter, birthYearMaxFilter);

Query q = new Query("Person").setFilter(birthYearRangeFilter);
// [END gae_java8_datastore_inequality_filters_one_property_valid_1]

// Assert
List<Entity> results =
Expand All @@ -498,7 +496,6 @@ public void queryRestrictions_compositeFilter_returnsMatchedEntities() throws Ex
public void queryRestrictions_compositeFilter_isInvalid() throws Exception {
long minBirthYear = 1940;
long maxHeight = 200;
// [START gae_java8_datastore_inequality_filters_one_property_invalid]
Filter birthYearMinFilter =
new FilterPredicate("birthYear", FilterOperator.GREATER_THAN_OR_EQUAL, minBirthYear);

Expand All @@ -508,7 +505,6 @@ public void queryRestrictions_compositeFilter_isInvalid() throws Exception {
Filter invalidFilter = CompositeFilterOperator.and(birthYearMinFilter, heightMaxFilter);

Query q = new Query("Person").setFilter(invalidFilter);
// [END gae_java8_datastore_inequality_filters_one_property_invalid]

// Note: The local devserver behavior is different than the production
// version of Cloud Datastore, so there aren't any assertions we can make
Expand Down Expand Up @@ -545,7 +541,6 @@ public void queryRestrictions_compositeEqualFilter_returnsMatchedEntities() thro
String targetCity = "Somewhere";
String targetLastName = "Someone";

// [START gae_java8_datastore_inequality_filters_one_property_valid_2]
Filter lastNameFilter = new FilterPredicate("lastName", FilterOperator.EQUAL, targetLastName);

Filter cityFilter = new FilterPredicate("city", FilterOperator.EQUAL, targetCity);
Expand All @@ -561,7 +556,6 @@ public void queryRestrictions_compositeEqualFilter_returnsMatchedEntities() thro
lastNameFilter, cityFilter, birthYearMinFilter, birthYearMaxFilter);

Query q = new Query("Person").setFilter(validFilter);
// [END gae_java8_datastore_inequality_filters_one_property_valid_2]

// Assert
List<Entity> results =
Expand Down