Skip to content

Bug/#1084 - Visual studio loading issue - #1087

Merged
FlorianRappl merged 5 commits into
ElectronNET:developfrom
epsitec-sa:bug/#1084
Jul 28, 2026
Merged

Bug/#1084 - Visual studio loading issue#1087
FlorianRappl merged 5 commits into
ElectronNET:developfrom
epsitec-sa:bug/#1084

Conversation

@epsnm

@epsnm epsnm commented Jul 27, 2026

Copy link
Copy Markdown
  • Fix visual studio loading issue
  • Let electron-builder choose current platform when not in WSL cross-compile mode
  • MSBuild configuration barriers to be included in projects with CPM

Comment thread src/ElectronNET.Host/ElectronNET.Host.esproj Outdated

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks great, but please keep existing JS.Sdk and I am not sure I understand the reason for pulling so many files into the root directory. From my perspective these changes are unrelated to the runtime identifier issue, but maybe I am not seeing the full picture here.

rvuistin and others added 2 commits July 28, 2026 06:54
- Moved Directory.Build.* barriers from nuke to root folder to cover all projects.
- Added a Directory.Packages.props barrier to stop central package management.
- Removed obsolete 'ManagePackageVersionsCentrally' properties.
@epsnm

epsnm commented Jul 28, 2026

Copy link
Copy Markdown
Author

After reading the tests results it seems only one macos test is in error (macos-15-intel API-30.4.0)

ElectronNET.IntegrationTests.Tests.BrowserWindowTests.Represented_filename_and_edited_flags()
[xUnit.net 00:00:35.49]         --- End of stack trace from previous location ---
  Failed Represented_filename_and_edited_flags [1 s]
  Error Message:
   System.TimeoutException : No response after 1000ms trying to retrieve value browserWindow.GetRepresentedFilenameAsync()
  Stack Trace:
     at ElectronNET.IntegrationTests.Tests.BrowserWindowTests.Represented_filename_and_edited_flags() in /Users/runner/work/Electron.NET/Electron.NET/src/ElectronNET.IntegrationTests/Tests/BrowserWindowTests.cs:line 248

I've didn't catch how it can be related to these changes. Did you have other tests-runs that sometime fail for no apparent reason ?

I'll investigate with a run-until-fail session on a similar macos version.

@FlorianRappl

Copy link
Copy Markdown
Collaborator

No need for this. Macos tests / machines are unfortunately flaky. Quite often just re-running the test on that particular image will succeed.

It's a different story if multiple/all are failing.

@github-actions

Copy link
Copy Markdown

pr-comment: Run #113

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
1540 1378 0 0 0 162 0 4m 17s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@FlorianRappl
FlorianRappl merged commit 820d7bb into ElectronNET:develop Jul 28, 2026
17 checks passed
@FlorianRappl FlorianRappl added this to the 0.5.2 milestone Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants