Retarget to .NET 10 and overhaul the README for the first release - #28
Merged
Conversation
The harness stays on net8.0 (no change needed there — a higher-TFM project referencing a lower one is standard and fully supported), but Desktop's own csproj was still net8.0-windows10.0.19041.0. Verified clean: a full rebuild, a forced restore, the 223-test suite, and a self-contained win-x64 Release publish all succeed against net10.0-windows10.0.19041.0 with the existing WindowsAppSDK 2.2.0 package. Also bumps both GitHub Actions workflows' pinned dotnet-version from 8.0.x to 10.0.x — left at 8.0.x, the release pipeline would have failed the moment this merged, since the runner would have no SDK able to build a net10.0 target.
The old README opened with submodule/harness plumbing before ever saying what the app does or why someone would want it. Restructured so a first- time visitor sees the value proposition, a screenshots section, and a benefit-driven feature list first; install/build instructions stay close to where they were. All of the deep internals that used to open the README — the harness pin and rolling instructions, the CLI/Desktop layer map, per-agent vs app-wide service tables, split view/snapshots/notes/history internals, why the tab strip isn't a TabView, and the full v0.1 feature inventory — move to a new docs/ARCHITECTURE.md wholesale. Nothing was cut, just relocated. docs/screenshots/README.md lists the exact filenames the new README's placeholders expect, so dropping images in that folder is the only step left to make them appear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated pieces of release prep, bundled together since both are small:
.NET 8 — that's expected and fully supported, a newer project can depend on an older one with
no changes needed on that side. Verified this is solid, not just "it compiled once": a clean
rebuild, a fully forced restore, the entire 223-test suite, and an actual self-contained
win-x64 Release publish (the same command the release pipeline runs) all succeed. Also caught
and fixed something that would have quietly broken the release the moment this merged: both
GitHub Actions workflows had the CI runner's .NET version hardcoded to 8.0, which would leave
it unable to build a .NET 10 target at all.
and internal architecture details before ever explaining what the app does. It now leads with
the pitch, a screenshots section, and a plain-language feature list; all the internals that
used to open the doc (harness pinning, per-agent architecture, split view/notes/snapshots
internals) got moved to a new
docs/ARCHITECTURE.mdrather than deleted.Test plan
dotnet buildsucceeds on this branch (confirmed locally, 0 warnings/errors)dotnet testpasses all 223 tests (confirmed locally)dotnet publish -c Release -r win-x64 --self-containedproduces a working exe (confirmedlocally)
this is the one thing I couldn't verify from a local machine, worth watching on this PR
docs/ARCHITECTURE.md)