Skip to content

Don't ship tibco stubs in agent - #11985

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/remove-tibco-stubs
Jul 17, 2026
Merged

Don't ship tibco stubs in agent#11985
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/remove-tibco-stubs

Conversation

@bric3

@bric3 bric3 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Tibco stubs are incorrectly shipped in the agent jar. This PR skips them.

Motivation

Cleanup.

They are also only included as compileOnly in other tibco modules.

compileOnly project(':dd-java-agent:instrumentation:tibco-businessworks:tibco-businessworks-stubs')

compileOnly project(':dd-java-agent:instrumentation:tibco-businessworks:tibco-businessworks-stubs')

Additional Notes

The new ugly if check should not be necessary once we have convention plugins in place, see #11620

This gains roughly 10KiB on agent Jar.

- .rw-r--r--@ 34,545,485 brice.dutheil 17 Jul 16:06  dd-java-agent/build/libs/dd-java-agent-1.65.0-SNAPSHOT.jar
+ .rw-r--r--@ 34,532,427 brice.dutheil 17 Jul 16:46  dd-java-agent/build/libs/dd-java-agent-1.65.0-SNAPSHOT.jar

Removed classes

jardiff --stat --color=never dd-java-agent-1.65.0-SNAPSHOT.jar dd-java-agent/build/libs/dd-java-agent-1.65.0-SNAPSHOT.jar -c classdata                                                      took 39s 16:46:06
 dd-java-agent.index                                                          | 2 +-
 inst/com/tibco/bw/jms/shared/api/receive/JMSMessageCallBackHandler.classdata | 7 -------
 inst/com/tibco/bx/core/behaviors/activity/BxEmptyBehavior.classdata          | 19 -------------------
 inst/com/tibco/bx/core/behaviors/activity/BxFlowBehavior.classdata           | 19 -------------------
 inst/com/tibco/bx/core/behaviors/activity/BxPickBehavior.classdata           | 19 -------------------
 inst/com/tibco/bx/core/behaviors/activity/BxScopeBehavior.classdata          | 19 -------------------
 inst/com/tibco/pe/PEVersion.classdata                                        | 28 ----------------------------
 inst/com/tibco/pe/core/ActivityGroup.classdata                               | 19 -------------------
 inst/com/tibco/pe/core/Job.classdata                                         | 41 -----------------------------------------
 inst/com/tibco/pe/core/JobPool.classdata                                     | 28 ----------------------------
 inst/com/tibco/pe/core/ProcessGroup.classdata                                | 19 -------------------
 inst/com/tibco/pe/core/Task.classdata                                        | 19 -------------------
 inst/com/tibco/pe/core/Workflow.classdata                                    | 16 ----------------
 inst/com/tibco/pe/plugin/Activity.classdata                                  | 19 -------------------
 inst/com/tibco/pe/plugin/Component.classdata                                 | 30 ------------------------------
 inst/com/tibco/pe/plugin/ProcessContext.classdata                            | 10 ----------
 inst/com/tibco/pvm/api/PmAttributed.classdata                                | 15 ---------------
 inst/com/tibco/pvm/api/PmModelObject.classdata                               | 10 ----------
 inst/com/tibco/pvm/api/PmModule.classdata                                    | 10 ----------
 inst/com/tibco/pvm/api/PmProcess.classdata                                   | 7 -------
 inst/com/tibco/pvm/api/PmProcessInstance.classdata                           | 13 -------------
 inst/com/tibco/pvm/api/PmTask.classdata                                      | 10 ----------
 inst/com/tibco/pvm/api/PmWorkUnit.classdata                                  | 13 -------------
 inst/com/tibco/pvm/api/behavior/PmBehavior.classdata                         | 10 ----------
 inst/com/tibco/pvm/api/event/PmEvent.classdata                               | 13 -------------
 inst/com/tibco/pvm/api/session/PmContext.classdata                           | 7 -------
 inst/com/tibco/pvm/api/util/attr/PmAttrFilter.classdata                      | 12 ------------
 inst/com/tibco/pvm/api/util/attr/PmAttribute.classdata                       | 10 ----------
 28 files changed, 1 insertions(+), 443 deletions(-)

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3
bric3 requested a review from mcculls July 17, 2026 14:56
@bric3 bric3 added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 17, 2026
@bric3
bric3 force-pushed the bdu/remove-tibco-stubs branch from 44b603b to 537cbf5 Compare July 17, 2026 15:01
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 57.26% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a27ce5a | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 13.88 s [+0.0%; +1.8%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.94 s 13.00 s [-1.2%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 16.89 s 16.04 s [+0.9%; +9.7%] (maybe worse)
startup:petclinic:iast:Agent 16.81 s 16.87 s [-1.2%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.68 s 16.95 s [-2.7%; -0.4%] (maybe better)
startup:petclinic:sca:Agent 16.89 s 16.09 s [+0.8%; +9.1%] (maybe worse)
startup:petclinic:tracing:Agent 15.98 s 15.99 s [-1.2%; +1.0%] (no difference)

Commit: a27ce5aa · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Comment thread dd-java-agent/instrumentation/build.gradle Outdated

@mcculls mcculls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Co-authored-by: Stuart McCulloch <stuart.mcculloch@datadoghq.com>
@bric3
bric3 marked this pull request as ready for review July 17, 2026 15:30
@bric3
bric3 requested a review from a team as a code owner July 17, 2026 15:30
@bric3
bric3 requested review from vandonr and removed request for a team July 17, 2026 15:30
@bric3

bric3 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-17 15:33:28 UTC ℹ️ Start processing command /merge


2026-07-17 15:33:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-17 16:22:05 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-17 17:44:26 UTC ℹ️ MergeQueue: This merge request was merged

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

This PR introduces a critical regression by reordering span lifecycle operations in ~60 instrumentation files. It closes the active scope AFTER finishing the span, contradicting explicit requirements in AGENTS.md that state decorator methods must execute while the scope is still active. This breaks IAST/AppSec callbacks and async span context propagation across all instrumented frameworks.

P0 Scope closed after span finished — violates documented lifecycle order

IAST/AppSec callbacks fail silently; security vulnerabilities not detected; async span context lost

P0 Documented scope lifecycle constraint removed from AGENTS.md

Future instrumentation code follows broken pattern; security-sensitive callbacks become unreliable

P0 Safety rationale removed from docs/how_instrumentations_work.md

Lost understanding of why order matters; no institutional knowledge for future maintenance

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit a27ce5a · What is Autotest? · Any feedback? Reach out in #autotest

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 0fddfc4 into master Jul 17, 2026
590 of 592 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/remove-tibco-stubs branch July 17, 2026 17:44
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling inst: others All other instrumentations tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants