Don't ship tibco stubs in agent - #11985
Conversation
44b603b to
537cbf5
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: a27ce5a | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Co-authored-by: Stuart McCulloch <stuart.mcculloch@datadoghq.com>
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
There was a problem hiding this comment.
This PR introduces a critical regression by reordering span lifecycle operations in ~60 instrumentation files. It closes the active scope AFTER finishing the span, contradicting explicit requirements in AGENTS.md that state decorator methods must execute while the scope is still active. This breaks IAST/AppSec callbacks and async span context propagation across all instrumented frameworks.
Scope closed after span finished — violates documented lifecycle order
IAST/AppSec callbacks fail silently; security vulnerabilities not detected; async span context lost
Documented scope lifecycle constraint removed from AGENTS.md
Future instrumentation code follows broken pattern; security-sensitive callbacks become unreliable
Safety rationale removed from docs/how_instrumentations_work.md
Lost understanding of why order matters; no institutional knowledge for future maintenance
Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · Commit a27ce5a · What is Autotest? · Any feedback? Reach out in #autotest
0fddfc4
into
master
What Does This Do
Tibco stubs are incorrectly shipped in the agent jar. This PR skips them.
Motivation
Cleanup.
They are also only included as
compileOnlyin other tibco modules.dd-trace-java/dd-java-agent/instrumentation/tibco-businessworks/tibco-businessworks-5.14/build.gradle
Line 4 in a51d7ed
dd-trace-java/dd-java-agent/instrumentation/tibco-businessworks/tibco-businessworks-6.5/build.gradle
Line 4 in a51d7ed
Additional Notes
The new ugly
ifcheck should not be necessary once we have convention plugins in place, see #11620This gains roughly 10KiB on agent Jar.
Removed classes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]