test: cover region normalization - #20
Merged
Merged
Conversation
afercal
marked this pull request as ready for review
July 28, 2026 14:24
afercal
requested review from
Scoombe,
huides00 and
siddhuwarrier
as code owners
July 28, 2026 14:24
Consistency CheckNo consistency issues found. Checker output |
huides00
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
normalize_sccfm_region.AUSalias, empty input, andNone.Why
This is a small, useful test-only change that can validate the SCCFM Jenkins trigger after
cisco-lockhart/ci#6933 is merged and seeded.
Merging this PR into
sccfm-devkit/mainshould start the SCCFM E2E job.Impact
No production behavior changes. This adds four unit-test cases only.
Validation
pytest cisco_sccfm_core/tests/test_constants.py— 4 passedpre-commit run --files cisco_sccfm_core/tests/test_constants.py— passedMerge order
Do not merge this PR until the CI trigger fix has been merged, the Jenkins job has been reseeded,
and one successful
BRANCH_NAME=mainE2E run has refreshed the SCM baseline.