VAPI-3162-REFER - #211
Open
atelegu wants to merge 17 commits into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
stampercasey
left a comment
stampercasey
left a comment
There was a problem hiding this comment.
Review from Claude Code — see inline comments for individual findings. Two blockers; the callback model and enums are solid.
stampercasey
previously approved these changes
Jun 22, 2026
The referComplete callback model will land later via a separate api-specs-driven PR once VAPI-3440 merges. This also removes the top-level Bandwidth::Refer model (and its ReferCompleteMethodEnum/ ReferCallStatusEnum helpers), which duplicated Bxml::Refer at the openapi-generator layer and had no equivalent for any other BXML verb (e.g. Transfer has no top-level Bandwidth::Transfer model). Adds a spec for Bxml::Refer covering construction with a bare SipUri and correct BXML rendering.
Bandwidth::SipUri (JSON model layer) and its bandwidth.yml schema were left over from the deleted top-level Refer/ReferCompleteCallback models and had no remaining consumer. .openapi-generator/FILES still listed refer.rb, refer_call_status_enum.rb, refer_complete_callback.rb, refer_complete_method_enum.rb, and their specs after those files were already deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
<Refer>BXML verb.lib/bandwidth-sdk/models/bxml/verbs/refer.rb: newBxml::Referverb, takessip_uriuntyped/shared - same patternTransferalready uses withBxml::SipUri, no separate Refer-only SipUri type and no cross-field validation restricting whichSipUriattributes are legal per verb (matches csharp-sdk#201, which dropped this as over-engineering).spec/unit/models/bxml/verbs/refer_spec.rb.ReferCompleteCallbackmodel is out of scope here - lands separately once VAPI-3440 merges. Deleted an orphanedBandwidth::SipUriREST/JSON model (lib/bandwidth-sdk/models/sip_uri.rb) and itsbandwidth.ymlschema that had no remaining consumer once that callback work was descoped.Tests:
bundle exec rspec spec/unit/models/bxml/verbs/refer_spec.rbpasses; no new failures inspec/unit.VAPI-3436