Skip to content

[ALICE3] Fix O2Linter issues in ALICE 3 DQ Framework - #17269

Open
axti98 wants to merge 2 commits into
AliceO2Group:masterfrom
axti98:ALICE3CodeCleanup
Open

[ALICE3] Fix O2Linter issues in ALICE 3 DQ Framework#17269
axti98 wants to merge 2 commits into
AliceO2Group:masterfrom
axti98:ALICE3CodeCleanup

Conversation

@axti98

@axti98 axti98 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 2 errors, ⚠️ 0 warnings, 🔕 0 disabled

@axti98
axti98 marked this pull request as ready for review July 31, 2026 07:42
@axti98

axti98 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@njacazio We might rename the tasks at some point so the linter errors there and in the CMakeList are also resolved, just to keep in mind

@alibuild

alibuild commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4ea8c3f at 2026-07-31 10:47:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 39 errors and 2 warnings.'
Found 39 errors and 2 warnings.
++ [[ 39 -gt 0 ]]
++ cat /sw/BUILD/3d2b778123b319f3ed498408b37a38541a5fa07b/O2Physics-code-check/errors.txt
ALICE3/TableProducer/alice3DqTableMaker.cxx:145:34: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:145:63: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:249:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:256:33: error: the parameter 'histClasses' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:305:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:311:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:338:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:356:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:399:17: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:400:81: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:417:8: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:428:53: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:432:34: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:436:8: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:439:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:462:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:463:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:464:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:471:25: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:482:59: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:487:32: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:490:80: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:492:12: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:495:12: error: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:501:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:570:21: error: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:571:102: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:582:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:613:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:630:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:652:28: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:669:28: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:678:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:679:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:692:13: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:693:12: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3DqTableMaker.cxx:697:10: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/Tasks/alice3DqEfficiency.cxx:334:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
ALICE3/Tasks/alice3DqEfficiency.cxx:1613:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/3d2b778123b319f3ed498408b37a38541a5fa07b/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/alice3DqTableMaker.cxx:136:35: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants