Pin reproducer CCDB queries to the original job's run time - #2427
Merged
sawenzel merged 1 commit intoJul 31, 2026
Merged
Conversation
Reproducers resolved CCDB against the present, so any object re-uploaded since the job ran silently changed the outcome -- e.g. FT0/Calib/EventsPerBc, whose late arrival flips o2-steer-colcontexttool to the non-uniform sampler and gives a different collision context at the same fixed seed. Inject ALICEO2_CCDB_CONDITION_NOT_AFTER, which BasicCCDBManager picks up, so it covers the anchoring stage as well as the workflow tasks. Only pin when the moment is actually known: $2 if given, else "now" when run inside the job itself (the anchorMC.sh path). Otherwise skip and say so -- a wrong pin is worse than none. Skipped too if the JDL already sets it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sawenzel
requested review from
chiarazampolli,
davidrohr and
shahor02
as code owners
July 31, 2026 13:18
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Contributor
Author
|
Companion to AliceO2Group/AliceO2#15653 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducers resolved CCDB against the present, so any object re-uploaded since the job ran silently changed the outcome -- e.g. FT0/Calib/EventsPerBc, whose late arrival flips o2-steer-colcontexttool to the non-uniform sampler and gives a different collision context at the same fixed seed.
Inject ALICEO2_CCDB_CONDITION_NOT_AFTER, which BasicCCDBManager picks up, so it covers the anchoring stage as well as the workflow tasks.
Only pin when the moment is actually known: $2 if given, else "now" when run inside the job itself (the anchorMC.sh path). Otherwise skip and say so -- a wrong pin is worse than none. Skipped too if the JDL already sets it.