Enable MSVC support for AArch64 code paths - #1305
Open
Harishmcw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_M_ARM64.Motivation
_M_ARM64instead of aarch64, causing those code paths to be excluded.This resulted in compilation errors such as:
Fix
This PR updates ARM64-specific code paths to support both GCC/Clang and MSVC by replacing architecture guards of the form:
#ifdef __aarch64__with
#if defined(__aarch64__) || defined(_M_ARM64)The changes include:
ActivationLayerInfo.h
float16_talias usinguint16_tas a binary-compatible 2-byte type. This preserves the ActivationLayerInfo layout across Clang and MSVC builds, preventing ABI mismatches.LUTManager.h
QuantizationInfo.h
NEReorderLayer.h
_M_ARM64.These changes ensure that both Clang/GCC and MSVC compile the same ARM64 code paths, providing consistent declarations, structure layouts, and behaviour across toolchains.